Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-donation): show proper email in donor detail metabox on donation detail page #3526

Merged
merged 3 commits into from
Jul 27, 2018
Merged

fix(admin-donation): show proper email in donor detail metabox on donation detail page #3526

merged 3 commits into from
Jul 27, 2018

Conversation

jaydeeprami
Copy link
Contributor

Description

This PR will fix #2985

  • Show email address as @ravinderk suggested on issue

donor_email

How Has This Been Tested?

  • Manually tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

ravinderk
ravinderk approved these changes Jul 27, 2018
View reviewed changes
Copy link
Collaborator

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaydeeprami Always use existing data objects to get data.

@ravinderk ravinderk merged commit b983477 into release/2.2.1 Jul 27, 2018
@ravinderk ravinderk deleted the issue/2985 branch July 27, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinderk ravinderk ravinderk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaydeeprami @ravinderk