fix(emails): Add backward compatibility for keys #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
requested changes
Aug 8, 2018
| @@ -82,6 +82,7 @@ public function add( $args ) { | |||
| 'context' => give_check_variable( $args['context'], 'empty', 'general' ), | |||
| 'is_admin' => (bool) $args['is_admin'], // Introduced in 2.2.1 | |||
| 'description' => $args['desc'], // deprecated in 2.2.1 | |||
| 'function' => $args['func'], // deprecated in 2.2.1 | |||
There was a problem hiding this comment.
@Sidsector9 remove this code. there is no need for this code.
ravinderk
requested changes
Aug 8, 2018
| @@ -1394,6 +1395,15 @@ function __give_211_bc_email_template_tag_param( &$args, $func_args = array() ) | |||
| 'is_admin' => false, | |||
| ); | |||
| } else { | |||
|
|
|||
| if ( array_key_exists( 'description', $args ) ) { | |||
There was a problem hiding this comment.
@Sidsector9 please write comment on code that it is for backward compatibility use desc or func instead
|
@ravinderk I made the changes, ready to merge. |
ravinderk
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3584
Description
This PR updates the method used to register email tags.
Screenshots (jpeg or gifs if applicable):
Checklist: