fix: correct default behavior of donor wall # 3744 #3752
Conversation
show all donation instead of just donor
|
@ravinderk I will review this PR tomorrow and test against multisite. I have one note so far...
I think this param should stay as |
|
We should consider an option in the shortcode builder to exclude donations without comments so that we avoid awkward layouts like this where an empty comment creates too much white space.
To achieve this in WPBR, I checked for content at the time in which the review (or in this case, the comment) was saved. If there was no content, then I flagged the review with a taxonomy term. While we can always add this feature later, we should consider whether it's necessary to identify these blank reviews sooner than later so that they can be queried and paginated in a performant manner. |
|
@ravinderk I have pulled the latest from this branch and ran Please confirm if you're able to see gravatars after you added the latest changes in this branch. If so, let's do a call to see what I'm missing. |
Remaining TasksRavinder
KevinAfter Ravinder fixes gravatars:
|
There was a problem hiding this comment.
@ravinderk Multisite functionality is working as expected. I have one remaining bug which needs addressed regarding donor wall behavior.
The option to Show Avatar is not working as expected. It always shows the circles with initials even when [give_donor_wall show_avatar="false"]. Please ensure avatars are hidden and we are not requesting gravatars if show_avatar="false" is in the shortcode.
It is possible for the shortcode builder to be taller than the viewport for certain shortcodes like `[give_donor_wall]`. In these cases, the user is unable to insert the shortcode because the button is outside the viewport in a modal window with no way to access it. This issue has been resolved by adding CSS that allows the modal window to scroll vertically if it is too tall for the viewport. Shorter modal windows will be centered vertically if they do not exceed 100% height.
Some themes such as Twenty Fifteen have overreaching styles that are affecting the appearance of the donor wall in negative ways especially in terms of spacing and typography. To improve the consistency of the donor wall appearance across themes, a selective use of `!important` has been added to prevent themes from breaking the donor wall layout and typography.
|
I have hardened the CSS for better consistency in spacing and typography across themes. I used the lessens learned from WPBR theme compatibility so these should hold up fairly well. Before/After:
|
|
@ravinderk Once you have fixed the |
# Conflicts: # templates/shortcode-donor-wall.php
Description
This PR will resolve #3744 #3745 #3758
How Has This Been Tested?
Check
Acceptance Criteriaof #3744 #3745Checklist:
Important notes and Questions
hide_empty(not useful, we hide empty donation by default)_give_anonymous_donationto comment and meta_key_give_has_commentto donor meta. Let me know you want to remove them but i will suggest to keep them till next two or three releases if we do not find them usefull then we will remove them.only_commentsshortcode attibutes which was allowing to show only donors which has comment and but now it will show donation with donor commentsSuggestion
avatarset totruein shortcode attribute then gravatar API query will be sent (equal tonumberparam ) which increases page load time. To improve page load performance we can render gravatar after page load with js:https://www.npmjs.com/package/gravatar-api[Created issue for that feat: load donor wall gravatars after page load #3758 ]give_donation_amountfn to render donation amount is the cause of increase query. We can create an alternative function where we will process donation amount in bulk but it will need update fee recovery and currency switcher plugin (Can we part of Stats API).