fix: display the correct receipt on a links from the donation history page #3778 #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto issue/3778
ravinderk
requested changes
Nov 13, 2018
ravinderk
requested changes
Nov 19, 2018
There was a problem hiding this comment.
@mehul0810 Make changes to give_can_view_receipt function as we discussed over slack call.
…nto issue/3778
|
@ravinderk I've tested and fixed minor issues I found after merging latest pull and implementing suggested changes. Also, added a new video for the missed scenario in earlier video. Video for "Confirm Email" Scenario.https://www.useloom.com/share/0ce016f2e2c04d34913e8b722c2da754 |
to show donation receipt
|
Email Access workflow is working fine for me on donation history page but not on the donation confirmation page:
|
Delaying the donation receipt placeholder ajax after all the conditional checks will help donation receipt and email access functionality to work properly
|
@ravinderk To resolve the issue you mentioned on donation confirmation is due to early usage of Check commit: f1d0712 |
ravinderk
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #3778
How Has This Been Tested?
I've tested this PR as per the acceptance criteria in the issue. Please check the video for more information.
Screenshots (jpeg or gifs if applicable):
Video Link: https://www.useloom.com/share/5be24b695a0342bc99efb68f4fc2e383
Types of changes
Bug fix (a non-breaking change which fixes an issue)
Checklist: