Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure donor mailing addresses match when exporting to csv #3971 #3988

Merged
merged 3 commits into from
Feb 6, 2019
Merged

fix: ensure donor mailing addresses match when exporting to csv #3971 #3988

merged 3 commits into from
Feb 6, 2019

Conversation

ravinderk
Copy link
Collaborator

@ravinderk ravinderk commented Feb 6, 2019 •
edited

Description

this PR will resolve #3971

How Has This Been Tested?

  1. Get address on basis of donor and user id
  2. Exporting donor CSV

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk
refactor: remove unused code
0a88ad0
@ravinderk
refactor: update give_get_donor_address fn
bd53125 
1) remove backward compatibility for user_id
2) add option to get donor address by user_id
@ravinderk
fix: update give_get_donor_address fn arguments
a509d0b 
to get donor address by user id
@DevinWalker DevinWalker merged commit e256397 into release/2.4.1 Feb 6, 2019
@DevinWalker DevinWalker deleted the issue/3971 branch February 6, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevinWalker DevinWalker Awaiting requested review from DevinWalker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ravinderk @DevinWalker