fix: support date formats with translated strings #4000 #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to clone exiting input field to add datepicker to this element and old field will be used to store date in standard format `yy-mm-dd`
also add support for timestamp
to input field value if standard-date data attribute is missing
DevinWalker
requested changes
Feb 19, 2019
| @@ -404,8 +404,8 @@ function give_form_search_query_filter( $wp ) { | |||
|
|
|||
| $wp->query_vars['date_query'] = | |||
| array( | |||
| 'after' => ! empty( $_GET['start-date'] ) ? give_get_formatted_date( $_GET['start-date'] ) : false, | |||
There was a problem hiding this comment.
What is the recommended usage of give_get_formatted_date() now?
There was a problem hiding this comment.
@DevinWalker This function does not work fine with translated localize date strings.
I updated the function description:
| @@ -621,11 +621,21 @@ public function date_filter_pre() { | |||
| $date_query = array(); | |||
|
|
|||
| if ( ! empty ( $this->args['start_date'] ) ) { | |||
| $date_query['after'] = give_get_formatted_date( $this->args['start_date'] ); | |||
| $date_query['after'] = date( | |||
There was a problem hiding this comment.
Lots more code, can this be done in a dryer way?
There was a problem hiding this comment.
@DevinWalker I did two tings here:
-
since
give_get_formatted_datedoes not work well with translated localized date strings, so we start usingdatefn to convert the date toMySQLdate format which is standard. -
Added support for the timestamp in
start_dateandend_datequery param.
* release/2.4.2: fix: process all possible export steps
DevinWalker
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will resolve #4000
How Has This Been Tested?
https://www.useloom.com/share/21c6e1cbafe747a7afb8ca772c2f62a7
Screenshots (jpeg or gifs if applicable):
Checklist: