Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve importer failing on setting JSON import #4097 #4098

Merged
merged 1 commit into from
May 9, 2019
Merged

fix: resolve importer failing on setting JSON import #4097 #4098

merged 1 commit into from
May 9, 2019

Conversation

ravinderk
Copy link
Collaborator

Description

this Pr will resolve #4097

How Has This Been Tested?

importing and exporting string

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk
Copy link
Collaborator Author

@ravinderk I tested this PR and found that @Benunc setting json file has text/html while mine has text/plain. For now, I allowed both real mime type. Let me know if you want me to debug and cause of two different mime file type

@ravinderk ravinderk merged commit 1ac51dc into release/2.5.0 May 9, 2019
@ravinderk ravinderk deleted the issue/4097 branch May 9, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: resolve importer failing on setting JSON import
1 participant
@ravinderk