Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHPUnit test for Give_Payments_Query #1893 #4149

Merged
merged 10 commits into from
Jun 25, 2019
Merged

Add PHPUnit test for Give_Payments_Query #1893 #4149

merged 10 commits into from
Jun 25, 2019

Conversation

ravinderk
Copy link
Collaborator

Description

This PR will fix #1893

How Has This Been Tested?

Running PHPUnit test on local

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk ravinderk requested a review from mehul0810 June 25, 2019 10:58
@ravinderk ravinderk changed the base branch from release/2.5.0 to release/2.5.1 June 25, 2019 12:02
mehul0810
mehul0810 approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@mehul0810 mehul0810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravinderk PHP unit tests are working fine. I think this PR is ready to merge.

@ravinderk ravinderk merged commit 1f1c50d into release/2.5.1 Jun 25, 2019
@ravinderk ravinderk deleted the issue/1893 branch June 25, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehul0810 mehul0810 mehul0810 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ravinderk @mehul0810