fix: only show nag when Stripe Premium is lower than 2.2.0 #4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving this issue and PR to my Sprint backlog as it still needs some improvement |
mehul0810
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
@DevinWalker I've tested this PR and found that there are few other improvements required to that notice. So, I've added my commits in the PR and tested it properly. Now, the notice will dismiss properly for 24 hours so it will not load on every refresh.
ravinderk
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only displays the Stripe + Recurring version notice check if Stripe is active and less than version
2.2.0.Resolves #4169
How Has This Been Tested?
Screenshots (jpeg or gifs if applicable):
Types of changes