Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add constant for TCPDF to function properly with ticketa #4216

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

DevinWalker
Copy link
Member

Description

TCPDF defines K_TCPDF_CALLS_IN_HTML as false by default as a security precaution. Because Tickera uses GiveWP's composer autoloaded TCPDF version (same version they use) the constant is set to false. Therefore, we will set it to true so the QR code feature works as expected.

Resolves #3880

How Has This Been Tested?

  • manually

Screenshots (jpeg or gifs if applicable):

2019-08-05_18-46-50

Types of changes

  • plugin compatibility

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@DevinWalker DevinWalker merged commit 743dd85 into release/2.5.4 Aug 6, 2019
@DevinWalker DevinWalker deleted the issue/3880 branch August 6, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: ensure compatibility with Tickera QR code
1 participant