fix: avoid fatal error with recurring donation using GiveWP core patch #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevinWalker
reviewed
Sep 20, 2019
|
|
||
| // Hardcoded recurring plugin basename to show notice even when recurring addon is deactivated. | ||
| $recurring_plugin_basename = 'give-recurring/give-recurring.php'; | ||
| $recurring_plugin_data = get_plugin_data( WP_CONTENT_DIR . '/plugins/' . $recurring_plugin_basename ); |
There was a problem hiding this comment.
@mehul0810 you should use https://developer.wordpress.org/reference/functions/plugin_dir_path/ or similar in case this isn't the standard path.
DevinWalker
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the fatal error issue when Stripe is not enabled payment gateway in GiveWP core and recurring
1.9.3is used.How Has This Been Tested?
Please check the testing video: https://www.loom.com/share/e65239b333124cd195e219a61afdcf70
Types of changes
Bugfix (non-breaking change which fixes an issue)
Checklist: