feature: add average donation report endpoint #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
requested changes
Jan 23, 2020
There was a problem hiding this comment.
@henryholtgeerts I already suggested caching functions here: #4437 (comment)
can we use them in this pr too?
Yep! Merged changes from that PR into this one, ref: e92b0ed |
henryholtgeerts
deleted the
feature/add-average-donation-report-endpoint-4425
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4425
This PR adds the 'average donation' endpoint which calculates average donation over time and returns a data object appropriate shaped to be used in the RESTMiniChart component. The endpoint calculates average donation for the entire given period, as well as the trend in average donation from the previous period.
How Has This Been Tested?
Tested locally and throws no errors in browser console. Passed PHPUnit tests.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: