Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: escape later #7234

Merged
merged 4 commits into from Mar 1, 2024
Merged

Enhancement: escape later #7234

merged 4 commits into from Mar 1, 2024

Conversation

glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Feb 15, 2024 •
edited

Resolves GIVE-244

Description

This PR implements escape good practices intended to improve code quality.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Feb 15, 2024
@glaubersilva glaubersilva marked this pull request as ready for review February 15, 2024 19:47
@glaubersilva glaubersilva changed the title Enhancement: scape "s" later Enhancement: escape later Feb 15, 2024
jonwaldstein
jonwaldstein approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rickalday
rickalday approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests

@JasonTheAdams JasonTheAdams changed the base branch from master to develop March 1, 2024 00:11
@JasonTheAdams JasonTheAdams merged commit 91d6bf9 into develop Mar 1, 2024
20 checks passed
@JasonTheAdams JasonTheAdams deleted the enhancement/scape-s-later-GIVE-244 branch March 1, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickalday rickalday rickalday approved these changes

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees

@glaubersilva glaubersilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glaubersilva @rickalday @jonwaldstein @JasonTheAdams