Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add HeaderImage settings #7241

Merged
merged 4 commits into from Feb 26, 2024

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Feb 20, 2024

Resolves GIVE-333

Description

This PR reintroduces the HeaderImage setting for both Classic & Multistep templates.

Feature: add HeaderImage to multistep template #7243

Refactor: add HeaderImage to classic template #7238

Feature: add form featured image migration step #7249

Affects

Classic & Multistep forms in the visual form builder

Testing Instructions

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual QA tests.

Copy link

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review February 26, 2024 15:09
@JoshuaHungDinh JoshuaHungDinh merged commit 904836d into develop Feb 26, 2024
32 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the epic/design-settings-header-images branch February 26, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants