Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Currency Switcher support to Event Tickets #7255

Conversation

pauloiankoski
Copy link
Contributor

Description

This pull request adds Currency Switcher compatibility to Event Tickets. It applies the current currency rate to amounts and formats them appropriately when switching currencies.

Visuals

CleanShot 2024-02-22 at 20 35 06

Testing Instructions

  1. Configure Currency Switcher with multiple currencies
  2. Add the Event Tickets block to a form
  3. Open the donation form
  4. Select tickets on the events field
  5. Change the donation form currency
  6. Confirm amounts and formatting are updated correctly

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

Base automatically changed from refactor/update-event-tickets-template to epic/events-GIVE-265 February 27, 2024 14:36
@pauloiankoski pauloiankoski force-pushed the feature/event-tickets-currency-switcher-compatibility branch from 46ae91d to eb98b02 Compare February 27, 2024 14:51
@pauloiankoski pauloiankoski marked this pull request as ready for review February 27, 2024 14:52
Copy link
Member

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool how straight forward that is to support in the new forms. So much better than v2 jQuery/DOM stuff.

@kjohnson kjohnson changed the title Feature: make Event Tickets compatible with Currency Switcher Feature: Add Currency Switcher support to Event Tickets Mar 1, 2024
@kjohnson kjohnson merged commit 845d003 into epic/events-GIVE-265 Mar 1, 2024
20 checks passed
@kjohnson kjohnson deleted the feature/event-tickets-currency-switcher-compatibility branch March 1, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants