Skip to content

Commit

Permalink
linter insists on single quotes
Browse files Browse the repository at this point in the history
  • Loading branch information
mengwong committed Mar 5, 2023
1 parent 4efdf40 commit 8d4a531
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 11 deletions.
4 changes: 2 additions & 2 deletions src/plugins/blackout/blackout.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
gc.addEventListener( document, "keydown", function( event ) {

// Accept b or . -> . is sent by presentation remote controllers
if ( [ "KeyB", "Period" ].includes(event.code) ) {
if ( [ "KeyB", "Period" ].includes( event.code ) ) {
event.preventDefault();
if ( !blackedOut ) {
blackout();
Expand All @@ -105,7 +105,7 @@
gc.addEventListener( document, "keyup", function( event ) {

// Accept b or . -> . is sent by presentation remote controllers
if ( [ "KeyB", "Period" ].includes(event.code) ) {
if ( [ "KeyB", "Period" ].includes( event.code ) ) {
event.preventDefault();
}
}, false );
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/help/help.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@

document.addEventListener( "keyup", function( event ) {

// "h" || "?" -- but this seems brittle, what about keyboards that don't have / ? together?
if ( [ "KeyH", "Slash" ].includes(event.code) ) {
// "h" || "?" // but this seems brittle, what about keyboards that don't have / ? together?
if ( [ "KeyH", "Slash" ].includes( event.code ) ) {
event.preventDefault();
toggleHelp();
}
Expand Down
14 changes: 8 additions & 6 deletions src/plugins/impressConsole/impressConsole.js
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@
// Trigger impress action on keyup
window.document.addEventListener( 'keyup', function( event ) {
if ( !event.ctrlKey && !event.altKey && !event.shiftKey && !event.metaKey &&
keys.includes( event.code) ) {
keys.includes( event.code ) ) {
handler();
event.preventDefault();
}
Expand Down Expand Up @@ -451,16 +451,18 @@

// Keyboard navigation handlers
// 33: pg up, 37: left, 38: up
registerKeyEvent( [ "PageUp", "ArrowLeft", "ArrowUp" ], window.impress().prev );
registerKeyEvent( [ 'PageUp', 'ArrowLeft', 'ArrowUp' ],
window.impress().prev );

// 34: pg down, 39: right, 40: down
registerKeyEvent( [ "PageDown", "ArrowRight", "ArrowDown" ], window.impress().next );
registerKeyEvent( [ 'PageDown', 'ArrowRight', 'ArrowDown' ],
window.impress().next );

// 32: space
registerKeyEvent( [ "Space" ], spaceHandler );
registerKeyEvent( [ 'Space' ], spaceHandler );

// 82: R
registerKeyEvent( [ "KeyR" ], timerReset );
registerKeyEvent( [ 'KeyR' ], timerReset );

// Cleanup
consoleWindow.onbeforeunload = function() {
Expand Down Expand Up @@ -565,7 +567,7 @@
};

//Open speaker console when they press 'p'
registerKeyEvent( [ "KeyP" ], open, window );
registerKeyEvent( [ 'KeyP' ], open, window );

//Btw, you can also launch console automatically:
//<div id="impress" data-console-autolaunch="true">
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/navigation/navigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
}

if ( "Space PageUp PageDown ArrowLeft ArrowRight ArrowUp ArrowDown"
.split(" ").includes(event.code) ) {
.split( " " ).includes( event.code ) ) {
return true;
}
};
Expand Down

0 comments on commit 8d4a531

Please sign in to comment.