Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce optional but standard css file for plugin related css #681

Closed
henrikingo opened this issue Mar 9, 2018 · 0 comments
Closed

Introduce optional but standard css file for plugin related css #681

henrikingo opened this issue Mar 9, 2018 · 0 comments

Comments

@henrikingo
Copy link
Member

impress.js doesn't require any particular CSS file. Each author should create their own, to achieve the visual style they want.

In practice, as we've added many plugins, a plugin will not do anything useful without CSS. (See for example mouse-timeout plugin.) The src/plugins/README.md provides example CSS that a user may want to copy paste.

It's significant enough, that it makes sense to move that CSS out into an actual css file, like css/impress-common.css. After that, all the demo presentations should be also changed to use that CSS file, and the same CSS should be removed from each of their own CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant