meta keys affecting tab #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dont let meta keys advance the presentation as they are used to change windows most often. Although ctrl + left and ctrl + right are used to go forward and back in history. this may need further testing and feedback
|
actually nevermind on further testing. using the meta key plus whatever key exits out of the handler and lets the browser use its native event, so ctrl+left will go back in history, which is handled with the hash change event handler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont let meta keys advance the presentation as they are used to change windows most often. Although ctrl + left and ctrl + right are used to go forward and back in history. this may need further testing and feedback