Add fullscreen with support to remote presentation controller #712
Conversation
giflw
commented
Jan 15, 2019
giflw
commented
- F5 to enter/exit
- Escape to exit
- F5 to enter/exit - Escape to exit
| var gc = api.lib.gc; | ||
| var util = api.lib.util; | ||
|
|
||
| gc.addEventListener( document, "keydown", function( event ) { |
There was a problem hiding this comment.
It would make sense to have only a single event listener, since both of them are "keydown".
Also, I think with the current code "F5" would execute both enterFullscreen() and exitFullscreen().
There was a problem hiding this comment.
Done changing to only one event listener. F5 indeed enter and exit full screen, as you requested earlier. It makes the behavior more intuitive when using keyboard, but allows the use of remote controller
There was a problem hiding this comment.
FWIW, F5 is used as the reload key in some popular browsers.
There was a problem hiding this comment.
That's a good point, and this code will now override that functionality.
I think compatibility with remote controllers is a good argument in favor though. Other than that I have no strong opinion.
There was a problem hiding this comment.
I think it's more intuitive to use F5 in presentations to enter fullscreen. I catch myself trying that some times. Besides that, remote controllers works as keyboards and send F5 key to enter fullscreen. This way impress.js becomes more friendly to power point and other common users that have remote controls.
Regarding browser reload, CTRL+R it's another common way to reload, an this is not changed by impress.js.
