Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery Tools tabs conflicts with jQuery UI tabs #201

Closed
jankus opened this issue Nov 19, 2012 · 5 comments
Closed

jQuery Tools tabs conflicts with jQuery UI tabs #201

jankus opened this issue Nov 19, 2012 · 5 comments
Labels

Comments

@jankus
Copy link
Contributor

jankus commented Nov 19, 2012

If you include both, one of them won't work. Currently found bug when using SimpleSlideshow plugin. Plugin works but inline management crashes.

Some kind of solution: http://stackoverflow.com/questions/4599916/jquery-tools-tabs-conflicts-with-jquery-ui

@jankus
Copy link
Contributor Author

jankus commented Nov 19, 2012

And yet official jQuery Tools response (nothing happy) - jquerytools/jquerytools#831

@jankus
Copy link
Contributor Author

jankus commented Nov 19, 2012

For the Simple Slideshow here's a quick fix.

In system.php file find this line:

        $site->addJavascript(BASE_URL.LIBRARY_DIR.'js/jquery-tools/jquery.tools.ui.tabs.js', 2);

And add these lines below:

        // solving $.tabs namespace issue: https://github.com/jquerytools/jquerytools/issues/831
        $site->removeJavascript(BASE_URL.LIBRARY_DIR.'js/jquery-ui/jquery-ui.js'); // removing original jquery-ui 
        $site->addJavascriptContent('changing-tabs-namespace','jQuery.fn.jtTabs = jQuery.fn.tabs;', 2); // changing namespace
        $site->addJavascript(BASE_URL.LIBRARY_DIR.'js/jquery-ui/jquery-ui.js', 3); // adding jquery-ui back again

Then in slideshow.js file find this line:

    $(".ipPluginSimpleSlideshowTabs").tabs(".ipPluginSimpleSlideshowImages > div", {

And change it to this:

    $(".ipPluginSimpleSlideshowTabs").jtTabs(".ipPluginSimpleSlideshowImages > div", {

All we do is renaming function name as we did in system.php file: from tabs to jtTabs (jQuery Tools tabs).

@algimantas
Copy link
Member

SimpleSlideshowPlugin should include this workaround.

@maskas
Copy link
Member

maskas commented Nov 23, 2012

I think it would be better to find some new library for simpleSlideshowPlugin which doesn't conflict.

@maskas
Copy link
Member

maskas commented Feb 7, 2013

Fixed in SimpleSlideshow 1.03 by replacing Tools tabs to Cycle tabs library. Also configuration options have been added. http://www.impresspages.org/extensions/plugins-2.x/simple-slideshow/

@maskas maskas closed this as completed Feb 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants