-
Notifications
You must be signed in to change notification settings - Fork 175
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery Tools tabs conflicts with jQuery UI tabs #201
Comments
And yet official jQuery Tools response (nothing happy) - jquerytools/jquerytools#831 |
For the Simple Slideshow here's a quick fix. In system.php file find this line: $site->addJavascript(BASE_URL.LIBRARY_DIR.'js/jquery-tools/jquery.tools.ui.tabs.js', 2); And add these lines below: // solving $.tabs namespace issue: https://github.com/jquerytools/jquerytools/issues/831
$site->removeJavascript(BASE_URL.LIBRARY_DIR.'js/jquery-ui/jquery-ui.js'); // removing original jquery-ui
$site->addJavascriptContent('changing-tabs-namespace','jQuery.fn.jtTabs = jQuery.fn.tabs;', 2); // changing namespace
$site->addJavascript(BASE_URL.LIBRARY_DIR.'js/jquery-ui/jquery-ui.js', 3); // adding jquery-ui back again Then in slideshow.js file find this line: $(".ipPluginSimpleSlideshowTabs").tabs(".ipPluginSimpleSlideshowImages > div", { And change it to this: $(".ipPluginSimpleSlideshowTabs").jtTabs(".ipPluginSimpleSlideshowImages > div", { All we do is renaming function name as we did in system.php file: from tabs to jtTabs (jQuery Tools tabs). |
SimpleSlideshowPlugin should include this workaround. |
I think it would be better to find some new library for simpleSlideshowPlugin which doesn't conflict. |
Fixed in SimpleSlideshow 1.03 by replacing Tools tabs to Cycle tabs library. Also configuration options have been added. http://www.impresspages.org/extensions/plugins-2.x/simple-slideshow/ |
If you include both, one of them won't work. Currently found bug when using SimpleSlideshow plugin. Plugin works but inline management crashes.
Some kind of solution: http://stackoverflow.com/questions/4599916/jquery-tools-tabs-conflicts-with-jquery-ui
The text was updated successfully, but these errors were encountered: