Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the sending of pre-announcement trailers #300

Open
johanbrandhorst opened this issue Jan 19, 2019 · 2 comments
Open

Re-enable the sending of pre-announcement trailers #300

johanbrandhorst opened this issue Jan 19, 2019 · 2 comments

Comments

@johanbrandhorst
Copy link
Contributor

Sometime between 1.9.2 and 1.18.0 the gRPC Go client started including the pre-announcement trailer headers in the header values read by the client. We should aim to provide the same experience, so I think we should turn on sending these. Specifically, it would mean removing the following lines from the proxy:

I briefly tested simply removing these lines and running some tests but it appears the client is blocking on something, and I haven't yet had the time to investigate where.

@johanbrandhorst
Copy link
Contributor Author

See improbable-eng/js-browser-headers#21 also.

@johanbrandhorst
Copy link
Contributor Author

Still investigating this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant