Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nhooyr.io/websocket from v1.8.6 to v1.8.7 #1063

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Bump nhooyr.io/websocket from v1.8.6 to v1.8.7 #1063

merged 1 commit into from
Nov 24, 2021

Conversation

a-krause
Copy link
Contributor

Changes

Bump nhooyr.io/websocket from v1.8.6 to v1.8.7
Required due to high severity security finding fixed with nhooyr/websocket#291

Verification

Verified locally grpcwebproxy builds and runs fine

@improbable-prow-robot improbable-prow-robot added the size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. label Nov 23, 2021
@johanbrandhorst
Copy link
Contributor

Lets retry the tests

@johanbrandhorst
Copy link
Contributor

9.511697 24 Nov 01:31:59 - error querying from https://saucelabs.com/rest/v1/****************/tunnels, error was: 400: Too many active user tunnels: 6 >= 5 (ref: f029edbf). HTTP status: 400 Bad Request

Wonder if we're restricted to 5 concurrent runners? CC @MarcusLongmuir

@johanbrandhorst
Copy link
Contributor

Seems like it, every time I retry a job another 5 of them pass. I wonder if we could set concurrency limits in CircleCI?

Copy link
Contributor

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit 80f5543 into improbable-eng:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants