Ensure headers from wrapped server is forwarded appropriately #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2019 08:57
This commit adds copyHeader func and options to grpc-web response logic.
johanbrandhorst
approved these changes
Feb 20, 2019
|
Rerunning the tests 🤔 |
johanbrandhorst
changed the title
johanbrandhorst
changed the title
|
@johanbrandhorst thanks for all your help! |
danilvpetrov
pushed a commit
to danilvpetrov/grpc-web
that referenced
this pull request
Feb 21, 2019
This commit makes websocket_wrapper.go file consistent with the changes in grpc_web_response.go file, PR improbable-eng#359.
johanbrandhorst
pushed a commit
that referenced
this pull request
Feb 21, 2019
This commit makes websocket_wrapper.go file consistent with the changes in grpc_web_response.go file, PR #359.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #334.
This approach adds 'copyHeader' function with multiple options to address repeatable code in
go/grpcweb/grpc_web_response.gofile and header preparation when underlying gRPC service callsWritemethod ongrpcWebResponseobject.The tests were copied from #339 originally done by @johanbrandhorst.