Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Websocket Cancellation Handling #917

Merged
merged 3 commits into from Mar 16, 2021
Merged

Fix Websocket Cancellation Handling #917

merged 3 commits into from Mar 16, 2021

Conversation

MarcusLongmuir
Copy link
Contributor

Changes

Verification

  • Tested locally using Chrome 89 and will check CI thoroughly

@improbable-prow-robot improbable-prow-robot added the size/L Denotes a PR that changes 150-299 lines, ignoring generated files. label Mar 16, 2021
johanbrandhorst
johanbrandhorst approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant Marcus :)

@MarcusLongmuir MarcusLongmuir mentioned this pull request Mar 16, 2021
Closed
@MarcusLongmuir MarcusLongmuir merged commit 604a83d into master Mar 16, 2021
@MarcusLongmuir MarcusLongmuir deleted the fix-websockets-899 branch March 16, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 150-299 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancelation event not cached by server
4 participants
@MarcusLongmuir @johanbrandhorst @improbable-prow-robot @watjurk