Assert more about the test server fixture #140
Conversation
| "//depot/file.txt": "Hello World\n", | ||
| "//stream-depot/main/file.txt": "Hello Stream World\n" |
There was a problem hiding this comment.
Content of files
| assert submitted_changeinfo == { | ||
| '1' :{ | ||
| 'action': ['add'], | ||
| 'depotFile': ['//depot/file.txt'], | ||
| 'desc': 'Initial Commit' | ||
| }, | ||
| '2' :{ | ||
| 'action': ['add'], | ||
| 'depotFile': ['//stream-depot/main/file.txt'], | ||
| 'desc': 'Initial Commit to Stream\n' | ||
| }, | ||
| '6' :{ | ||
| 'action': ['edit'], | ||
| 'depotFile': ['//depot/file.txt'], | ||
| 'desc': 'modify //depot/file.txt\n' | ||
| }, | ||
| } |
There was a problem hiding this comment.
If tests fail, it shows you a rich diff of exactly which bits were different
| 'action': ['edit'], | ||
| 'depotFile': ['//depot/file.txt'], | ||
| 'desc': 'Modify file in shelved change\n', | ||
| # Change content from 'Hello World\n' to 'Goodbye World\n' |
There was a problem hiding this comment.
Hopefully the comment suffices here
If there are more complex shelved changes created we could look at fetching the content of the shelved change and including it here. Omitted for the sake of simplicity for now
There was a problem hiding this comment.
Actually on second though this might be really useful to include the content, as it means we can put this static info in a global var for the unit tests and refer to it from throughout, avoiding potential mistakes
There was a problem hiding this comment.
Maybe in a future PR...
There was a problem hiding this comment.
I'd be up for making that, it's been a while since I python'd.
|
@commanderofthegrey Could you take a look at this? Thanks |
| } | ||
|
|
||
| # Check submitted changes | ||
| submitted_changes = [change for change in repo.perforce.run_changes('-s', 'submitted')] |
There was a problem hiding this comment.
Is there a long-form flag instead of -s, for readability?
There was a problem hiding this comment.
unfortunately not, it means status
|
|
||
| # Check shelved changes | ||
| shelved_changes = [change for change in repo.perforce.run_changes('-s', 'pending')] | ||
| shelved_changeinfo = {change["change"]: repo.perforce.run_describe('-S', change["change"])[0] for change in shelved_changes} |
There was a problem hiding this comment.
unfortunately not, it means get info for shelved files on this change
hopefully this is implied from the var it is being assigned to
|
I'm not sure I understand enough what is going on... :/ |
|
We have a zip of a perforce server which is used to run unit tests against and this asserts around some state it has, otherwise its a bit of a 'black box' as to what is on the server |
Improve code-as-documentation on what the server fixture contains
In lieu of work on issue #111