Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS files #12

Merged
merged 1 commit into from Oct 6, 2020
Merged

Add OWNERS files #12

merged 1 commit into from Oct 6, 2020

Conversation

DoomGerbil
Copy link

No functional change, but this will hook up Prow for PR auto-assignment and notification, as noted in #11.

@improbable-prow-robot improbable-prow-robot added the size/S Denotes a PR that changes 15-39 lines, ignoring generated files. label Oct 5, 2020
@DoomGerbil
Copy link
Author

(Auto-assignment explicitly keys off of the value of the OWNERS file in the merge target to prevent shenanigans, so this will be active once this PR merges)

@@ -0,0 +1,11 @@
---
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This OWNERS file is primarily added as a demonstration for how authors of specific scripts can add themselves on a per-file basis.

@improbable-prow-robot improbable-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@DoomGerbil DoomGerbil added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@improbable-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: petemounce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@improbable-prow-robot improbable-prow-robot merged commit 5ed46b3 into master Oct 6, 2020
@improbable-prow-robot improbable-prow-robot deleted the owners-files branch October 6, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 15-39 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants