Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install project with bazel using a local_repository #101

Closed
coltonmorris opened this issue Aug 12, 2018 · 2 comments
Closed

Install project with bazel using a local_repository #101

coltonmorris opened this issue Aug 12, 2018 · 2 comments

Comments

@coltonmorris
Copy link
Contributor

coltonmorris commented Aug 12, 2018

I'd like to start pulling in the package similar to how rules_typescript does - which is by including all of the pertinent bazel files in the npm package, and then in your workspace using a local_repository. Not only will this make installing easier by following a convention, but it also cleans up some dependency version snafus.

Some changes to achieve this:

  • Include the defs.bzl file in the npm package (I could use some direction on this one).
  • Build the protoc plugin binary within bazel differently. It currently relies on the src directory which isn't part of the npm package. Can investigate just pulling in the binary, or building using the lib directory.
  • Update readme.
  • Test to compare bazel's binary with the non-bazel one.
@coltonmorris coltonmorris changed the title Include bazel custom rule in npm package Install project with bazel using a local_repository Aug 12, 2018
@coltonmorris
Copy link
Contributor Author

#129

Shy'd away from using the local_repository, and cleaned up the installation instead.

@stale
Copy link

stale bot commented Jan 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 15, 2019
@stale stale bot closed this as completed Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants