Handling of enums

[mattvagni]

More detail in: #156

Changes

• This changes how the type generation handles protobuf enums
• Regenerated all examples to run tests against

Verification

I checked and there seem to be a fair few tests for enum handling, the code changes are backwards compatible so they were not modified. Not sure if there are any additional tests worth writing? I did however have to change some of the casting in the integration test for maps - not sure if the changes makes sense though 🤔

[jonny-improbable]

LGTM.

Technically this is not a breaking change as anyone that was relying on the enum behavior would have problems at runtime :D

[mattvagni]

Haha brave 😅 Ok, thanks for merging this so quickly.

[jonny-improbable]

Fortune favours the brave... plus we can rely on feedback from the community if anything goes proper bang :D

You can dogfood it yourself by upgrading to 0.9.1-pre.901b08e via npm.

[mahileeb]

Hi,

this change is causing compile errors for our app where we use the enum as a field type, e.g. the mode field in the below

type OwnProps = {
    name?: string;
    mode?: EnvironmentMode;
    version?: string;
    build?: string;
    className?: string;
}

causes

(8,12): 'EnvironmentMode' refers to a value, but is being used as a type here.

If I use the generated EnvironmentModeMap interface then it will compile

[mattvagni]

@mahileeb Could it be that you are importing EnvironmentMap object from the generated js client, not the typescript type?

Otherwise an example repo/gist would be helpful in order for me to help.

[mahileeb]

Hmm, the import looks like:

import { EnvironmentMode } from "protobuf/generated/com/mahifx/model/echo_protomap_pb";

Is that the correct way to import it? Here's gist of the proto schema and the usage: https://gist.github.com/mahileeb/1ce0c625634d10595351c1110711901f

[jacobfederer]

Any update on this issue? This is the dealbreaker for upgrading to 0.10 and higher.

[yoyomolinas]

With #157 many of us are unable to use Protobuf enums with Typescript. As pointed out in #187 and #268, I think this issue needs further attention. Any clarification appreciated.

[thesayyn]

There is an alternative plugin that you can use to solve this.
See: thesayyn/protoc-gen-ts#39

[screenpunch]

We're also stuck with 0.9, this change has made protobuf enums unusable for us also.