Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the bazel-related library versions #160

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Updates the bazel-related library versions #160

merged 1 commit into from
Apr 4, 2019

Conversation

Dig-Doug
Copy link
Contributor

@Dig-Doug Dig-Doug commented Apr 3, 2019

Also updates the grpc-web version.

@jonny-improbable
Copy link
Contributor

package-lock.json needs updating, please run nvm use && npm install in the root of the project and check-in the resulting changes.

@Dig-Doug
Copy link
Contributor Author

Dig-Doug commented Apr 4, 2019

Done. I also updated the bazel version for the CI and added a .bazelignore file for node_modules.

Copy link
Contributor

@jonny-improbable jonny-improbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, so LGTM :)

Thanks for continuing to provide Bazel support.

@jonny-improbable jonny-improbable merged commit aa468e9 into improbable-eng:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants