Fire state changed events #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jun 12, 2021
bramkragten
force-pushed
the
fire-state-changed-events
branch
from
f3b1086
to
f478cbb
Compare
balloob
reviewed
Jun 14, 2021
balloob
reviewed
Jun 14, 2021
| @@ -17,5 +19,8 @@ export const startProvisioning = async () => { | |||
|
|
|||
| const el = document.createElement("improv-wifi-provision-dialog"); | |||
| el.device = device; | |||
| el.stateUpdateCallback = (state) => { | |||
| fireEvent(button, "state-changed", state); | |||
There was a problem hiding this comment.
Let's make detail an object so we can expand it while remaining backwards compatibility.
Suggested change
| fireEvent(button, "state-changed", state); | |
| fireEvent(button, "state-changed", { state }); |
There was a problem hiding this comment.
It is an object, stateUpdateCallback receives an object.
balloob
approved these changes
Jun 14, 2021
|
Don't forget to update the README. |
bramkragten
force-pushed
the
fire-state-changed-events
branch
from
8003b07
to
3f59119
Compare
balloob
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.