Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not update state once provisioned #13

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Do not update state once provisioned #13

merged 2 commits into from
Jun 14, 2021

Conversation

balloob
Copy link
Contributor

@balloob balloob commented Jun 13, 2021

  • Merge "disconnected" state into "error" state
  • Add option to await RPC command and get result
  • Disconnect when provisioned
  • Do not show spinner on clicking "next" on provisioned screen. This would lock the user in a dialog they can't quit if they open the NEXT link in a new tab.

Fixes #12

@balloob balloob requested a review from bramkragten June 13, 2021 06:13
balloob
balloob commented Jun 14, 2021
View reviewed changes
src/provision-dialog.ts
@state() private _state:
| "connecting"
| "improv-state"
| "disconnected"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged disconnected state into error state

@balloob balloob merged commit a88b3ea into main Jun 14, 2021
@balloob balloob deleted the freeze-state branch June 14, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Freeze state once we hit provisioned state
2 participants
@balloob @bramkragten