Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: await startNotifications() calls #132

Merged
merged 2 commits into from
Apr 11, 2022
Merged

fix: await startNotifications() calls #132

merged 2 commits into from
Apr 11, 2022

Conversation

rpardini
Copy link
Contributor

Otherwise we get random, unrelated, errors during provisioning, for "Unknown reason".

See

balloob
balloob reviewed Apr 11, 2022
View reviewed changes
src/ble.ts Outdated Show resolved Hide resolved
@rpardini rpardini requested a review from balloob April 11, 2022 18:24
balloob
balloob approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit 429066d into improv-wifi:main Apr 11, 2022
@rpardini rpardini deleted the pr_await_startNotifications branch April 12, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rpardini @balloob