Fix event name for state change #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo for the event name "state-changed"
Hide "false" string in the dialog when showClose is false at rendermessage
balloob
reviewed
Nov 18, 2022
| @@ -179,7 +179,7 @@ export class ImprovBluetoothLE extends EventTarget { | |||
| const state = encodedState.getUint8(0) as ImprovCurrentState; | |||
| this.logger.debug("improv current state", state); | |||
| this.currentState = state; | |||
| this.dispatchEvent(new CustomEvent("state-change")); | |||
| this.dispatchEvent(new CustomEvent("state-changed")); | |||
There was a problem hiding this comment.
We shouldn't fix the typo as that's a breaking change. It's been there and so that's it. Instead we should fix the readme.
There was a problem hiding this comment.
Hi, I think this is not just a typo. The modal dialog ('Press the authorize button on the device') waits endless after the charackteristic state is changed (e.g. state '1' to '2').
The dialog is advised to a "state-changed") but this event will never raised.
There was a problem hiding this comment.
Then let's fix the event listener. That way we can avoid a breaking change.
There was a problem hiding this comment.
@balloob The event is referred to as state-changed when dispatched on line 140. One of them realistically has to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo for the event name "state-changed"