Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature first steps #3

Merged
merged 6 commits into from Jun 9, 2016
Merged

Feature first steps #3

merged 6 commits into from Jun 9, 2016

Conversation

jimdelois
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 9, 2016 •
edited

Coverage Status

Coverage increased (+100.0%) to 100.0% when pulling 657da95 on jimdelois:feature-first-steps into 4068ad6 on improvframework:master.

Allowing Travis CI Failures for HHVM
de8998a 
Sadly, Travis CI pulls HHVM 3.6.6 for its build, directly from the distro. As can be seen here, facebook/hhvm@5bd38ec#diff-60d29ccbc84f4563554014aa69f57d73 , the use of `ARRAY_FILTER_USE_KEY` was not introduced in HHVM until a later version. This is causing the build to fail, which isn't critical to the project
@coveralls
Copy link

coveralls commented Jun 9, 2016 •
edited

Coverage Status

Coverage increased (+100.0%) to 100.0% when pulling de8998a on jimdelois:feature-first-steps into 4068ad6 on improvframework:master.

@jimdelois jimdelois merged commit ea1ca2e into improvframework:master Jun 9, 2016
@jimdelois jimdelois deleted the feature-first-steps branch September 25, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimdelois @coveralls