Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: add hls support for internal streams #525

Merged
merged 12 commits into from
Jun 7, 2024

Conversation

synzr
Copy link
Contributor

@synzr synzr commented May 26, 2024

related to #510

this pr adds conversion of chunk links within HLS playlists into istreams

src/modules/stream/internal.js Outdated Show resolved Hide resolved
src/modules/stream/internal.js Outdated Show resolved Hide resolved
src/modules/stream/internal.js Outdated Show resolved Hide resolved
src/modules/stream/internal.js Outdated Show resolved Hide resolved
src/modules/stream/internal.js Outdated Show resolved Hide resolved
@dumbmoron dumbmoron self-requested a review May 30, 2024 20:48
@synzr synzr requested a review from wukko May 31, 2024 11:52
Copy link
Member

@dumbmoron dumbmoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@synzr synzr requested a review from dumbmoron May 31, 2024 12:17
@wukko wukko changed the title HLS support for internal streams stream: hls support for internal streams Jun 7, 2024
Copy link
Member

@wukko wukko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
bandit

@wukko wukko changed the title stream: hls support for internal streams stream: add hls support for internal streams Jun 7, 2024
@wukko wukko merged commit 68f311c into imputnet:current Jun 7, 2024
4 checks passed
@synzr
Copy link
Contributor Author

synzr commented Jun 7, 2024

FINALLY

@wukko
Copy link
Member

wukko commented Jun 7, 2024

sorry i was very busy and couldn't lock in

@synzr synzr deleted the improvement/hls-istream branch June 7, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants