Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get pantry doesn't return list of baskets #19

Closed
richcorbs opened this issue Apr 30, 2020 · 5 comments · Fixed by #20
Closed

Get pantry doesn't return list of baskets #19

richcorbs opened this issue Apr 30, 2020 · 5 comments · Fixed by #20
Assignees
Labels
bug Something isn't working

Comments

@richcorbs
Copy link

Hey, this looks neat so far.

When I GET my pantry there is a JSON key for baskets: [] but it is an empty array.

I have a basket and can GET the basket using the API.

Should the basket names be displayed in the pantry's list of baskets?

@richcorbs
Copy link
Author

Oh interesting, when the basket is named the same as the pantry it is not included in the list of baskets.

@richcorbs
Copy link
Author

Or when the basket name matches the pantry name at all it doesn't show up in the list of baskets.

My pantry is named "richcorbs". Baskets "richcorbs" and "richcorbs2" do not show up in the GET pantry baskets list.

@richcorbs
Copy link
Author

Maybe a GET for a record that doesn't exist could get a 404 instead of a 400? The request was fine but there wasn't a record.

@imRohan
Copy link
Owner

imRohan commented Apr 30, 2020

Ahh, thanks for the heads up! I believe you may be right, there may also be something wonky going on with how I'm retrieving the baskets from Redis.

This may have something to do with the cursor that is returned via Redis executing scan

@imRohan imRohan self-assigned this May 2, 2020
@imRohan
Copy link
Owner

imRohan commented May 2, 2020

@richcorbs A fix for this issue was deployed early today. Closing the issue for now, but if the issue persists, ill reopen.

@imRohan imRohan closed this as completed May 2, 2020
@imRohan imRohan added the bug Something isn't working label May 4, 2020
@imRohan imRohan linked a pull request May 18, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants