add test to ensure assignees are passed in as strings, fix #1

imsky · Mar 2, 2017 · fb4e821 · fb4e821
1 parent 04b9d49
commit fb4e821
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/src/github/index.js b/src/github/index.js
@@ -140,6 +140,14 @@ function getBlameForCommitFile (resource) {
 }
 
 function assignUsersToResource (resource, assignees) {
+  assignees = assignees || [];
+
+  for(var i = 0; i < assignees.length; i++) {
+    if (typeof assignees[i] !== 'string') {
+      throw Error('Assignees must be specified as strings');
+    }
+  }
+
   return github.issues.addAssigneesToIssue({
     'owner': resource.owner,
     'repo': resource.repo,

diff --git a/test/review-test.js b/test/review-test.js
@@ -270,7 +270,29 @@ describe('(unit)', function () {
     });
 
     it('#getBlameForCommitFile');
-    it('#assignUsersToResource');
+
+    describe('#assignUsersToResource', function () {
+      it('works correctly', function () {
+        ghapi.post('/repos/OWNER/REPO/issues/1/assignees').reply(200);
+
+        return github.assignUsersToResource({
+          'owner': 'OWNER',
+          'repo': 'REPO',
+          'number': '1'
+        }, ['test']);
+      });
+
+      it('fails with non-text assignees', function () {
+        (function () {
+          github.assignUsersToResource({
+            'owner': 'OWNER',
+            'repo': 'REPO',
+            'number': '1'
+          }, [{}]);
+        }).should.throw(Error, 'Assignees must be specified as strings');
+      });
+    });
+
     it('#postPullRequestComment');
 
     it('#getRepoFile', function () {