re-create pr https://github.com/imsnif/synp/pull/32 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsnif
requested changes
Jun 10, 2019
There was a problem hiding this comment.
Hey @bluelovers - thanks again for this change! Just a comment about naming and then we can merge.
| const yarnTree = buildYarnTree(nodeModulesTree, packageLock) | ||
| return lockfile.stringify(yarnTree) | ||
| } | ||
| } |
There was a problem hiding this comment.
I like this change, but I don't like the function names. Could we change them to: convertYarnToNpm and convertNpmToYarn? What do you think?
There was a problem hiding this comment.
hmm? the name is from ur
const { buildYarnTree, buildNpmTree } = require('./tree')or u mean this 2
yarnToNpmCore
npmToYarnCore
There was a problem hiding this comment.
Yeah, I don't like the -core suffix.
imsnif
approved these changes
Jun 10, 2019
|
Merged and published as 1.5.0. Thanks for this, @bluelovers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-create pr before rename pkg name
#32