Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ACS module exploded the size of the library #31

Closed
depryf opened this issue Apr 13, 2018 · 3 comments
Closed

New ACS module exploded the size of the library #31

depryf opened this issue Apr 13, 2018 · 3 comments

Comments

@depryf
Copy link
Member

depryf commented Apr 13, 2018

This library was already pretty big because of all the resources it contains.

A few months ago, we added a new "acslinkage" module and added two new CSV resource files. I didn't notice at the time how big this is. They added more than 20MB of compressed data (so they added 20MB to the size of the JAR file). That's really a lot.

We found this out because we noticed that our SEER*DMS WAR files got bigger. This also affected other software like the SEER Data Viewer and the SEER Abstracting tool.

I am not sure what the answer is. Right now only one software uses the acslinkage. We might need to consider moving the resources to that project (but still keep the algorithm in this library; hopefully the algorithm was designed with a data producer pattern).

@depryf
Copy link
Member Author

depryf commented Apr 13, 2018

We discussed this internally and we would like this module to be moved out of this library since it's only referenced from one project.

@depryf
Copy link
Member Author

depryf commented Apr 16, 2018

@howew moved the ACS module into his software; it can be removed from this library at any time.

depryf added a commit that referenced this issue Apr 16, 2018
@depryf
Copy link
Member Author

depryf commented Apr 16, 2018

This work as been completed.

@depryf depryf closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant