Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache client property #22

Merged
merged 9 commits into from
Oct 31, 2017
Merged

Cache client property #22

merged 9 commits into from
Oct 31, 2017

Conversation

khornberg
Copy link
Contributor

No description provided.

@khornberg
Copy link
Contributor Author

test_signature_works_when_url_contains_escapsed_spaces is failing for me under python 2 and Django 1.7. It was added in 2b8f12d

The url seems to now have the %20 translated into (a space) and thus the validation fails.

With python 3.4 and Django 1.8 all tests pass.
This also breaks with Django 1.11 and 1.7.

imt-salt
imt-salt approved these changes Oct 28, 2017
View reviewed changes
Copy link

@imt-salt imt-salt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll approve in case you need this to move forward

@khornberg khornberg closed this Oct 31, 2017
@khornberg khornberg reopened this Oct 31, 2017
@khornberg khornberg merged commit e08ad36 into imtapps:master Oct 31, 2017
@khornberg khornberg deleted the feature/cache branch October 31, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imt-salt imt-salt imt-salt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khornberg @imt-salt