Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status stay in retrying #53

Open
jamalyan opened this issue Apr 5, 2020 · 8 comments
Open

Status stay in retrying #53

jamalyan opened this issue Apr 5, 2020 · 8 comments

Comments

@jamalyan
Copy link

jamalyan commented Apr 5, 2020

Hi there. I am trying to use this great package at first time.
But I got one issue.
When job get exception, the status not changing to 'failed', but stay 'retrying'.
In DefaultEventManager I have changed exceptionOccurred method functionality to get what I need.

'status' => ($event->job->attempts() == $event->job->maxTries()) ? $this->getEntity()::STATUS_FAILED : $this->getEntity()::STATUS_RETRYING,

AidasK added a commit to AidasK/laravel-job-status that referenced this issue Jun 26, 2020
@sstankov
Copy link

sstankov commented Jul 6, 2020

Just we verify we experienced the same one.

imTigger added a commit that referenced this issue Sep 19, 2020
@o15a3d4l11s2
Copy link

o15a3d4l11s2 commented May 10, 2021

Despite the fix I am still getting this issue - if the job fails, status stay as 'retrying', although the job is moved to the failed_jobs table by Laravel and there are no more retries. I think this is also related to #63.

@mylemans
Copy link

Despite the fix I am still getting this issue - if the job fails, status stay as 'retrying', although the job is moved to the failed_jobs table by Laravel and there are no more retries. I think this is also related to #63.

Same issue here. Any update on this?

To add, this gets logged in the failed jobs table:

Illuminate\Queue\MaxAttemptsExceededException: Modules\Platform\Jobs\XXX\XXXJob has been attempted too many times or run too long. The job may have previously timed out.

'Causer' of the exception is using the WithoutOverlapping middleware

@JuanS
Copy link
Contributor

JuanS commented Dec 12, 2021

Having the same problem here, made a PR #72

@mylemans
Copy link

@imTigger Any idea when you'll publish a new release with this fix?

@MathiasWeisheit
Copy link

@mylemans what can we do do get the change in a new release?

@mylemans
Copy link

mylemans commented Sep 9, 2022

@mylemans what can we do do get the change in a new release?

Why are you asking me? ;D

@MathiasWeisheit
Copy link

That's right!
I already searched for forks with more engagement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants