Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flexio clock gate #139

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Add flexio clock gate #139

merged 1 commit into from
Jul 3, 2023

Conversation

Finomnis
Copy link
Contributor

@mciantyre mciantyre force-pushed the flexio branch 2 times, most recently from 5d53cc4 to 1f735b4 Compare June 14, 2023 23:58
mciantyre
mciantyre approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@mciantyre mciantyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Checked 10xx additions against the reference manuals. I'm including clock gates for the 1170 MCUs.

mciantyre
mciantyre reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@mciantyre mciantyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I spoke too soon. Looks like there's a flexio module naming issue down in imxrt-ral. Appears to affect 1011 and 1021 chip selections.

@mciantyre mciantyre mentioned this pull request Jun 15, 2023
Closed
@Finomnis
Copy link
Contributor Author

Finomnis commented Jun 15, 2023 •
edited

@mciantyre It is also broken for the 1015 chip. Note that there are no 1015 CI checks in this crate yet, although the chip exists in imxrt-ral.

@Finomnis @mciantyre
Add FlexIO clock gates
ee76313 
1000 clock gates checked against RMs for the 1010, 1020, 1050, and 1060
MCUs. 1100 clock gates checked against 1170 RM.

Inside of 1000-series chip modules, there are collections of clock gates
aggregated by their root clock. These collections can help when bulk
changing clock gates before a root clock update. This commit does not
implement a corresponding collection for FlexIO root clocks. Besides the
IPG, the FlexIO root clocks are dedicated for their FlexIO peripheral
instance. Users can change the single corresponding clock gate before
updating the root clock. (Ignoring the edge case that FlexIO3 on the
1060 uses the FlexIO2 root clock.)
@mciantyre mciantyre merged commit ee76313 into imxrt-rs:main Jul 3, 2023
31 checks passed
@Finomnis Finomnis deleted the flexio branch July 3, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mciantyre mciantyre mciantyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Finomnis @mciantyre