Use defmt-rtt and panic-probe for evk boards #141
Conversation
|
Happy to merge this or something similar. Ping me if integrating becomes troublesome, and I can help out.
I'm OK with this, but this breaking change might require extra work to integrate. Another approach is to disable all default imxrt-log features in I'm also OK with chucking imxrt-log in favor of defmt-rtt throughout. Teensy 4 users would need to fend for themselves. |
SpinFast
force-pushed
the
imxrt-defmt-rtt
branch
2 times, most recently
from
c70f5db
to
b5f4a3b
Compare
SpinFast
force-pushed
the
imxrt-defmt-rtt
branch
from
b5f4a3b
to
33195af
Compare
|
Believe I've fixed the remaining CI issues. I don't have an 1170evk to test on. I tried a few variations on not removing defmt as a default feature for imxrt-log but ran into strange issues with cargo workspaces and features. |
SpinFast
force-pushed
the
imxrt-defmt-rtt
branch
2 times, most recently
from
9d0cbaf
to
14b9d21
Compare
The evk boards have a built in debug probe. When running firmware with probe-rs defmt-rtt provides a very fast channel of low cost debug println's that everyone finds really helpful. Using panic-probe with defmt-rtt has a second benefit in allowing for programs to inform probe-rs the firmware has exited cleanly. This can be used for writing samples and tests that exit. This also makes the imxrt-log defmt feature optional to the boards otherwise the two implementations of the defmt logger cause duplicate symbols to show up. Tested on an 1010evk and 1060evk.
Cargo doc errored noting that the explicit target is redundent, so remove it to fix the error.
SpinFast
force-pushed
the
imxrt-defmt-rtt
branch
from
14b9d21
to
964be75
Compare
|
This passes CI now and doesn't remove the defmt from the default features of imxrt-log |
Following the precedent of other EVKs. Tested on hardware.
We can't detect a dependency's features in our build. We can show this by modifying the rtic_logging example to use the Frontend::Defmt frontend, then building the example for a Teensy 4. The example fails to build. We can only detect our own features in our build. Add a board feature that we can enable for a board, and rewrite the conditional includes to use the feature.
The evk boards have a built in debug probe. When running firmware with probe-rs defmt-rtt provides a very fast channel of low cost debug println's that everyone finds really helpful.
Using panic-probe with defmt-rtt has a second benefit in allowing for programs to inform probe-rs the firmware has exited cleanly. This can be used for writing samples and tests that exit.
This also makes the imxrt-log defmt feature optional to the boards otherwise the two implementations of the defmt logger cause duplicate symbols to show up.