Remove the cortex_m module #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the Cortex-M peripheral API from imxrt-ral. Consider using the cortex-m crate to access CM peripherals. This is a breaking change, since there may be users who are depending on the cortex_m module in imxrt-ral.
The special member was set to True whenever the device represented a Cortex-M device. Since we're no longer supporting Cortex-M peripherals, we don't need to distinguish these kinds of devices.
Since we don't have to distinguish between our cortex-m module, and the external cortex-m dependency, we can bring back the default name for the cortex-m crate.
mciantyre
force-pushed
the
remove-cortexm
branch
from
569d7c3
to
a654420
Compare
Closed
teburd
approved these changes
Apr 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes the
imxrt_ral::cortex_mmodule from the crate. We remove all build steps, all CM-related SVDs and patches, and the code generation routines.This is a breaking change. Users who are interested in an API for Cortex-M peripherals should consider the
cortex-mcrate.Closes #7.