Add french translation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
commented
Nov 17, 2022
| linkModalTips: { | ||
| title: 'Ajouter un lien', | ||
| descLable: 'Texte ：', | ||
| descLablePlaceHolder: 'Entrez un texte...', |
There was a problem hiding this comment.
I noticed a typo everywhere Lable instead of Label but I'm guessing it can't be changed without a breaking change (unless we add a fallback)
Tofandel
commented
Nov 17, 2022
| clip2upload: 'Télécharger et recadrer', | ||
| }, | ||
| linkModalTips: { | ||
| title: 'Ajouter un lien', |
There was a problem hiding this comment.
There is a problem with how the title of the link modal is handled because it's used by both the link and img components a shortcut was taken to use one title with something appended
https://github.com/imzbf/md-editor-v3/blob/main/MdEditor/layouts/Modals/Link.tsx#L49
This doesn't allow for correct translations and needs to be changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.