Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITE-11 Feature Requests #55

Open
adityasaky opened this issue Feb 22, 2024 · 0 comments
Open

ITE-11 Feature Requests #55

adityasaky opened this issue Feb 22, 2024 · 0 comments

Comments

@adityasaky
Copy link
Member

This issue collects feature requests / suggestions for ITE-11.

Debug / error messages for attribute check failures

Proposed by @MarkLodato in https://github.com/in-toto/ITE/pull/50/files#r1344473474.

A raw list of CEL expressions might be a bit limiting. If something fails, it's difficult to present a clear error message of what went wrong. You might want to have a field for error messages. (Similarly, giving each an optional name might make it more readable.)

For example:

expectedAttributes:
  - name: builderId
    require: "predicate.runDetails.builder.id == 'https://example.com/myBuilder'"
    errorMessage: '"Unexpected builder.id: expected \"https://example.com/myBuilder\", got " + predicate.runDetails.builder.id'
  - name: repository
    require: "predicate.externalParameters.repository == '<expected value>'"
    errorMessage: '...'

Cross-step / predicate attribute checks

Proposed by @trishankatdatadog.

Right now, attribute checks are applied against the predicate / step they are specified for. The idea is to have checks that cut across a step or predicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant