New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(witness): witness should not error on an empty git repo with no commits #51

Merged

kriscoleman merged 1 commit into main from fix/issue272-fix-git-attestor-for-empty-git-repos

Aug 1, 2023

Contributor

kriscoleman commented Jul 28, 2023

Fixes in-toto/witness#275

When witness runs on an empty git repo without commits, it shouldn't error with reference not found

reproduction

start a new git repo, do not make any commits
run witness on it
observe witness fail

acceptance criteria

witness doesn't fail on step 3

jkjell approved these changes

View reviewed changes


          fix(witness): witness should not error on an empty git repo with no c…

b238634

…ommits

Fixes #121

kriscoleman force-pushed the fix/issue272-fix-git-attestor-for-empty-git-repos branch from 3476823 to b238634 Compare

August 1, 2023 19:01

coveralls commented Aug 1, 2023

Pull Request Test Coverage Report for Build 5730790106

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 48.494%

Totals
Change from base Build 5591257680:	0.07%
Covered Lines:	1433
Relevant Lines:	2955

💛 - Coveralls

kriscoleman merged commit 2357401 into main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment