-
Notifications
You must be signed in to change notification settings - Fork 51
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix different checksum calculation in RecordArtifact
This adds a bytes.ReplaceAll directive in the RecordArtifact function, that replaces all CRLF line separators with LF line separators. We see LF line separators as our normalized format.
- Loading branch information
Showing
2 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
04b13d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff. FYI, the reference implementation provides a flag to toggle this (see in-toto/in-toto#230). I don't think this is necessary for now, but we should definitely document the behavior in RecordArtifact's docstring.
04b13d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukpueh I have added a few sentences in the RecordArtifact docstrings. You might want to have a look :)