Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential bug in InTotoRun #124

Closed
shibumi opened this issue Sep 10, 2021 · 1 comment
Closed

Potential bug in InTotoRun #124

shibumi opened this issue Sep 10, 2021 · 1 comment
Assignees
@shibumi @adityasaky
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@shibumi
Copy link
Collaborator

shibumi commented Sep 10, 2021 •
edited
Loading

Description of issue or feature request:

in-toto-golang/in_toto/runlib.go

Line 293 in 02b98c8

byProducts, err := RunCommand(cmdArgs, runDir)

We are not handling an empty cmdArgs either as nil or empty string slice. We should check if our code still works with both and that we are not running into a panic.

Furthermore, we should add tests to cover these edge cases.
@shibumi shibumi added the bug Something isn't working label Sep 10, 2021
@adityasaky adityasaky added the good first issue Good for newcomers label Sep 11, 2021
@shibumi shibumi mentioned this issue Sep 11, 2021
Closed
u5surf added a commit to u5surf/in-toto-golang that referenced this issue Sep 11, 2021
@u5surf
Add error returns if command invalid in RunCommand in-toto#124
bfa1d8e
@u5surf u5surf mentioned this issue Sep 11, 2021
Closed
2 tasks
@shibumi shibumi mentioned this issue Sep 11, 2021
Merged
2 tasks
@adityasaky
Copy link
Member

Closed by #126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shibumi shibumi

@adityasaky adityasaky

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error returns if command invalid in RunCommand #124 u5surf/in-toto-golang
2 participants
@shibumi @adityasaky