-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: skip tests if gpg is not installed #208
Conversation
This is based off of the #206 PR, but it's not necessary. It's also not time sensitive, but a good to have... |
A summary of the changes is needed for someone attempting to review this pull request. Is there a reason why you opted to skip the GPG tests on Windows? There might be GPG behavior on Windows that we'd want to catch via these integration tests. It might be better to install GPG in Appveyor and not skip tests. We can look at how other projects make sure that a modern version of GPG is installed. See this appveyor config for an example. There is also a decent help page for installing GPG in Appveyor: Note: This pull request contains commits for parameter substitution. It's hard to judge what's relevant to this pull request (GPG testing on Windows) and what should be ignored (parameter substitution). |
Agreed. Will provide something soon.
I will clarify in the description, but it's not specific to windows, but rather installations that do not have windows installed and want to run the tests. This speeds up the suite execution.
Yes, I'll review this, although that may be more relevant for #207
Right. Now that ParamSubs is there, I'll rebase and re-push. |
83cdfb8
to
3b6642a
Compare
@awwad @trishankatdatadog could I get a review on this PR? I don't want it to grow stale... |
These tests will continue failing until we merge #211 |
I guess it's fine. Like @vladimir-v-diaz, I'm not a big fan of skipping GPG, but this should be fine. |
No description provided.