Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: skip tests if gpg is not installed #208

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Conversation

SantiagoTorres
Copy link
Member

No description provided.

@SantiagoTorres
Copy link
Member Author

This is based off of the #206 PR, but it's not necessary. It's also not time sensitive, but a good to have...

@coveralls
Copy link

coveralls commented May 23, 2018

Coverage Status

Coverage decreased (-0.05%) to 99.945% when pulling 3b6642a on skip-tests-no-gpg into 30880f6 on develop.

@awwad awwad self-requested a review May 25, 2018 19:58
@vladimir-v-diaz
Copy link
Contributor

A summary of the changes is needed for someone attempting to review this pull request.

Is there a reason why you opted to skip the GPG tests on Windows? There might be GPG behavior on Windows that we'd want to catch via these integration tests. It might be better to install GPG in Appveyor and not skip tests. We can look at how other projects make sure that a modern version of GPG is installed. See this appveyor config for an example. There is also a decent help page for installing GPG in Appveyor:
https://help.appveyor.com/discussions/questions/20054-installing-gnupg-for-tests

Note: This pull request contains commits for parameter substitution. It's hard to judge what's relevant to this pull request (GPG testing on Windows) and what should be ignored (parameter substitution).

@SantiagoTorres
Copy link
Member Author

A summary of the changes is needed for someone attempting to review this pull request.

Agreed. Will provide something soon.

Is there a reason why you opted to skip the GPG tests on Windows?

I will clarify in the description, but it's not specific to windows, but rather installations that do not have windows installed and want to run the tests. This speeds up the suite execution.

There might be GPG behavior on Windows that we'd want to catch via these integration tests. It might be better to install GPG in Appveyor and not skip tests. We can look at how other projects make sure that a modern version of GPG is installed. See this appveyor config for an example. There is also a decent help page for installing GPG in Appveyor:
https://help.appveyor.com/discussions/questions/20054-installing-gnupg-for-tests

Yes, I'll review this, although that may be more relevant for #207

Note: This pull request contains commits for parameter substitution. It's hard to judge what's relevant to this pull request (GPG testing on Windows) and what should be ignored (parameter substitution).

Right. Now that ParamSubs is there, I'll rebase and re-push.

@SantiagoTorres
Copy link
Member Author

@awwad @trishankatdatadog could I get a review on this PR? I don't want it to grow stale...

@SantiagoTorres
Copy link
Member Author

These tests will continue failing until we merge #211

@trishankatdatadog
Copy link
Member

I guess it's fine. Like @vladimir-v-diaz, I'm not a big fan of skipping GPG, but this should be fine.

@SantiagoTorres SantiagoTorres merged commit 21bb947 into develop Sep 19, 2018
@SantiagoTorres SantiagoTorres changed the title WIP: tests: skip tests if gpg is not installed tests: skip tests if gpg is not installed Sep 19, 2018
@SantiagoTorres SantiagoTorres deleted the skip-tests-no-gpg branch October 31, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants